fix: prevent parsing empty responses from throwing

[iamacook]

What it solves

Empty respones from thorwing on parse.

How this PR fixes it

When json() is called on the fetch response, it is caught. It would otherwise throw if there is no response JSON to parse.

The endpoints in question which caused this error are the proposal/confirmation of Safe messages.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[schmanu]

Should we check here if the header?.get("content-length") is greater than 0 and throw in that case?
It would mean that something was returned in the response which is not valid.

[iamacook]

It will not throw if the "content-length" is "0".

[schmanu]

I think it should be like this:

Suggested change

	if (resp.headers && resp.headers.get('content-length') === '0') {
	throw new Error('Empty response. ' + resp.statusText)
	if (resp.headers && resp.headers.get('content-length') !== '0') {
	throw new Error('Response has invalid format: ' + resp.text())

Otherwise we would throw if a response is empty (which we want to avoid with this PR)

[schmanu]

Ah wait. After calling resp.json() we cannot call resp.text() anymore. So i would probably just throw like this:
throw new Error('Response has invalid format: ')

[iamacook]

Good catch. I've adjusted it as suggested.

[schmanu]

Looking good now :) Let's gooo