Skip to content

Conversation

@iamacook
Copy link
Contributor

@iamacook iamacook commented Nov 29, 2022

What it solves

  1. Marks safeAppId as optional (which matches that of the transaction service and the gateway here). No safeAppId is present when testing adding a custom app.
  2. Adds getSafeMessage endpoint for retrieving a SafeMessage by hash. It does not return a type as seen here.
  3. Adds messagesTag to Safe info endpoint (as seen here).

@iamacook iamacook added the blocked Blocked by external dependencies label Nov 29, 2022
@iamacook iamacook self-assigned this Nov 29, 2022
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook marked this pull request as ready for review November 29, 2022 11:27
@iamacook iamacook requested a review from katspaugh November 29, 2022 11:27
@iamacook iamacook changed the title DON'T MERGE: fix: make safeAppId optional + add messagesTag fix: make safeAppId optional + add messagesTag Nov 29, 2022
@iamacook iamacook changed the title fix: make safeAppId optional + add messagesTag fix: make safeAppId optional, add messagesTag + message endpoint Nov 29, 2022
@iamacook iamacook removed the blocked Blocked by external dependencies label Nov 29, 2022
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iamacook iamacook merged commit 95a32a8 into main Nov 29, 2022
@iamacook iamacook deleted the safe-messages-adjustments branch November 29, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants