Skip to content

Refactor: allow both get and post methods on the same endpoint #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 24, 2022
Merged

Refactor: allow both get and post methods on the same endpoint #101

merged 3 commits into from
Nov 24, 2022

Conversation

@katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 24, 2022 •
edited
Loading

We can now clearly differentiate GET and POST endpoints by passing or not passing a body param.

@katspaugh katspaugh requested a review from iamacook November 24, 2022 12:44
@github-actions
Copy link

github-actions bot commented Nov 24, 2022 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@katspaugh katspaugh merged commit 93e51a0 into main Nov 24, 2022
@katspaugh katspaugh deleted the get-post branch November 24, 2022 15:19
katspaugh added a commit that referenced this pull request Nov 24, 2022
@katspaugh
Refactor: allow both get and post methods on the same endpoint #101 (#…
998e981 
…102)

* Merge main

* getEndpoint + postEndpoint

* Prettier

* Add tsc to the lint job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iamacook iamacook iamacook approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@katspaugh @iamacook