Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4337 issues #904

Merged
merged 8 commits into from
Jul 15, 2024
Merged

fix: 4337 issues #904

merged 8 commits into from
Jul 15, 2024

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Jul 9, 2024

What it solves

Resolves #903

  • Convert dates (validAfter and validUntil) for transaction service
  • Concat paymaster and paymasterData fields from transaction service
  • Adjust pimlico estimator
  • use addSafeOperation() with the API response instead calculating values
  • Update bundler to v2
  • Fix issue in send-safe-operations playground
  • Use preparedSignature from transaction service

@yagopv yagopv linked an issue Jul 9, 2024 that may be closed by this pull request
@yagopv
Copy link
Member Author

yagopv commented Jul 9, 2024

paymasterAndData issues solved as well here safe-global/safe-eth-py#1210

@dasanra dasanra marked this pull request as draft July 10, 2024 14:33
@yagopv yagopv marked this pull request as ready for review July 12, 2024 09:00
@yagopv yagopv requested a review from dasanra July 12, 2024 09:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9906664438

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 74.631%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 9809678697: 0.2%
Covered Lines: 789
Relevant Lines: 987

💛 - Coveralls

@yagopv yagopv merged commit 2d4d92a into development Jul 15, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
@yagopv yagopv deleted the fix/4337-issues branch July 16, 2024 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK Refactoring] Safe Operations not working in safe-kit
3 participants