-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predict safe address util #415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update safe-deployments version number * Add new networks
a8841fc
to
552bb50
Compare
552bb50
to
f9f00b4
Compare
germartinez
approved these changes
Apr 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #355
How this PR fixes it
Added
predictSafeAddress
as a util functionAdded
encodeSetupCallData
as a util functionRemoved
calculateProxyAddress
and using now the newpredictSafeAddress
util functionRemoved
getSafeInitializer
and using now the newencodeSetupCallData
util functionOther changes
Now we are using the
PREDETERMINED_SALT_NONCE
as a default value for thesaltNonce
in theSafeFactory
instead of the old defaultsaltNonce
based on the timestamp:see this comment
Tests
Added
predictSafeAddress
unit tests: