Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safe Service Client #31

Merged
merged 30 commits into from
Aug 13, 2021
Merged

Add Safe Service Client #31

merged 30 commits into from
Aug 13, 2021

Conversation

germartinez
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@germartinez germartinez linked an issue Jun 14, 2021 that may be closed by this pull request
@geigerzaehler
Copy link

This is much appreciated!

While trying this out in Radicle Upstream we realized that getPendingTransactions(safeAddress) for a safe that does not exist yet returns an object that does not match the return type. It returns the object { nonce_Gte: ["Enter a number"] }. Now that we know that we can react to it but having incorrect types made this a bit confusing. In general it seems that error responses are just returned as-is. It would be great if these were reflected in the return type or would instead throw an exception 🙇‍♂️

@germartinez germartinez changed the base branch from main to development August 9, 2021 12:04
@germartinez germartinez requested a review from mmv08 August 10, 2021 17:08
Copy link
Member

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@viraj124
Copy link

@germartinez what's the eta of this merge?
since I was facing this problem
safe core sdk has a execute transaction method which requires an object of SafeTransaction interface, but on the @gnosis.pm/safe-core-sdk & @gnosis.pm/safe-service-client there is no read method that returns the SafeTransaction object by providing the txHash
looks like this or solves that issue by the return type matching what execute transaction method needs

@viraj124
Copy link

basically, I am looking for a read method that returns an object of SafeTransaction interface

@germartinez germartinez merged commit 137e7dd into development Aug 13, 2021
@germartinez germartinez deleted the transaction-service branch August 13, 2021 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants