Skip to content

Fix Web3 tests #147

Closed
Closed
@germartinez

Description

Context / issue

Current state of the tests does not allow to run them initializing the SDK with web3. Only ethers.js works.

ethers.js works because it doesn't need the ABI of a contract in order to instantiate it, but web3 does.

After the integration of safe-deployments, web3 tests started to fail because only the ABI of the contracts deployed in the networks included in safe-deployments are found. safe-deployemtnscan't find the ABIs for contracts deployed in the local network (tests).

To do:

  1. Get the ABI of the Safe related contracts deployed to the local network during tests.
  2. Add the ABIs to the type ContractNetworksConfig
  3. Pass the ABIs using optional props to the methods where the contracts are instantiated.
  4. Add web3 tests to CI for Safe v1.2.0 and v1.3.0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions