Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally inject supportedCapabilities #81

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conditionally inject supportedCapabilities #81

merged 1 commit into from
Jun 21, 2024

Conversation

gavinbunney
Copy link
Contributor

When using this library in multi-os builds, the sys/unix flags for ETHTOOL_LINK_MODE_* fail to compile on darwin. This PR moves them into a ethtool_linux.go specific source file, and a stub in ethtool_darwin.go to not have any supportedCapabilities.

@safchain safchain merged commit 6585e3f into safchain:master Jun 21, 2024
1 check passed
@gavinbunney
Copy link
Contributor Author

Thanks for the quick merge! Would you be able to tag a new release as well? 🙏

@safchain
Copy link
Owner

I published a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavinbunney @safchain