Reduce flushing (performance)

safatshahin · Jul 19, 2023 · bcf39ea · bcf39ea
1 parent 16ba3ac
commit bcf39ea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/application/src/Controller/BackOfficeController.php b/application/src/Controller/BackOfficeController.php
@@ -119,9 +119,9 @@ public function backOfficeReset(string $serverID) : JsonResponse
                 ->findBy(['serverid' => $serverID]);
             foreach ($entities as $entity) {
                 $entityManager->remove($entity);
-                $entityManager->flush();
             }
         }
+        $entityManager->flush();
 
         return new JsonResponse((object) ['reset' => true]);
     }

diff --git a/application/src/Controller/SynapseController.php b/application/src/Controller/SynapseController.php
@@ -322,16 +322,15 @@ public function deleteRoom(string $serverID, string $roomID, Request $request):
                 ->findBy(['serverid' => $serverID, 'roomid' => $roomID]);
         foreach ($roommembers as $entity) {
             $entityManager->remove($entity);
-            $entityManager->flush();
         }
 
         $room = $this->getDoctrine()
                 ->getRepository(Rooms::class)
                 ->findBy(['roomid' => $roomID]);
         if (!empty($room)) {
             $entityManager->remove($room[0]);
-            $entityManager->flush();
         }
+        $entityManager->flush();
 
         return new JsonResponse((object) [
             'delete_id' => substr(hash('sha256', (date("Ymdhms"))), 0, 18)