Skip to content

Commit

Permalink
KVM: split out kvm_free_assigned_irq()
Browse files Browse the repository at this point in the history
Split out the logic corresponding to undoing assign_irq() and
clean it up a bit.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
markmc authored and avikivity committed Dec 31, 2008
1 parent 6155236 commit 4a643be
Showing 1 changed file with 22 additions and 7 deletions.
29 changes: 22 additions & 7 deletions virt/kvm/kvm_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -200,27 +200,42 @@ static void kvm_assigned_dev_ack_irq(struct kvm_irq_ack_notifier *kian)
enable_irq(dev->host_irq);
}

static void kvm_free_assigned_device(struct kvm *kvm,
struct kvm_assigned_dev_kernel
*assigned_dev)
static void kvm_free_assigned_irq(struct kvm *kvm,
struct kvm_assigned_dev_kernel *assigned_dev)
{
if (irqchip_in_kernel(kvm) && assigned_dev->irq_requested_type)
free_irq(assigned_dev->host_irq, (void *)assigned_dev);
if (assigned_dev->irq_requested_type & KVM_ASSIGNED_DEV_HOST_MSI)
pci_disable_msi(assigned_dev->dev);
if (!irqchip_in_kernel(kvm))
return;

kvm_unregister_irq_ack_notifier(&assigned_dev->ack_notifier);

if (assigned_dev->irq_source_id != -1)
kvm_free_irq_source_id(kvm, assigned_dev->irq_source_id);
assigned_dev->irq_source_id = -1;

if (!assigned_dev->irq_requested_type)
return;

if (cancel_work_sync(&assigned_dev->interrupt_work))
/* We had pending work. That means we will have to take
* care of kvm_put_kvm.
*/
kvm_put_kvm(kvm);

free_irq(assigned_dev->host_irq, (void *)assigned_dev);

if (assigned_dev->irq_requested_type & KVM_ASSIGNED_DEV_HOST_MSI)
pci_disable_msi(assigned_dev->dev);

assigned_dev->irq_requested_type = 0;
}


static void kvm_free_assigned_device(struct kvm *kvm,
struct kvm_assigned_dev_kernel
*assigned_dev)
{
kvm_free_assigned_irq(kvm, assigned_dev);

pci_reset_function(assigned_dev->dev);

pci_release_regions(assigned_dev->dev);
Expand Down

0 comments on commit 4a643be

Please sign in to comment.