Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: neoconf integration #134

Merged
merged 2 commits into from
Jun 19, 2024
Merged

feat: neoconf integration #134

merged 2 commits into from
Jun 19, 2024

Conversation

KaitlynEthylia
Copy link
Contributor

closes #132

neoconf does most of the heavy lifting, just added an additional function when building the config to overlay any local settings gotten from neoconf

Copy link
Owner

@saecki saecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little issue and a few nitpicks related to code formatting, otherwise this looks good!

lua/crates/config/init.lua Outdated Show resolved Hide resolved
lua/crates/config/init.lua Outdated Show resolved Hide resolved
lua/crates/config/init.lua Outdated Show resolved Hide resolved
lua/crates/config/init.lua Outdated Show resolved Hide resolved
@KaitlynEthylia
Copy link
Contributor Author

Done, might be worth adding a stylua.toml (or otherwise) to the file at some point, :p

or if there was a style guide and I just missed it, mb

@saecki
Copy link
Owner

saecki commented Jun 19, 2024

LGTM!

As for the style, I'm using the builtin formatter of lua_ls but as far as I can tell there are no options to enforce function call parenthesis or multi-line if statements. The current settings live in the .editorconfig file. But I don't think that's documented anywhere yet.

@saecki saecki merged commit 652279b into saecki:main Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neoconf integration
2 participants