Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SDK): support p2wsh format #124

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

kevzzsk
Copy link
Collaborator

@kevzzsk kevzzsk commented Jul 29, 2024

What this PR does / why we need it:

PR is to support creating outputs to p2wsh addresses.

Native segwit estimate is taken off https://medium.com/coinmonks/on-bitcoin-transaction-sizes-part-2-9445373d17f4

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors
  • Unit tests*
  • Added e2e tests*

@kevzzsk kevzzsk self-assigned this Jul 29, 2024
packages/sdk/src/utils/index.ts Outdated Show resolved Hide resolved
packages/sdk/src/utils/index.ts Outdated Show resolved Hide resolved
@dcorral
Copy link

dcorral commented Jul 29, 2024

LGTM

@kevzzsk kevzzsk merged commit 7a2d645 into sadoprotocol:main Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants