Fix broken dependsOn support introduced by Nova 4.7 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR recreates build using latest
DependentFormFieldmixin which is Nova 4.8.0 at the time of creation.As you may know when
dependsOnis triggered it sends a request to the nova api.4.7.0 added a
componentfield to the request which needs to contain the component name.Ths is required for the API to correctly resolve the field and call the required
dependsOncallbacks.If you search the diff on this PR for
this.field.componentyou will see its missing in the oldfield.jsexists in the newfield.js.Before
update-fields?editing=true&editMode=update&field=collection_hours
After
update-fields?editing=true&editMode=update&field=collection_hours&component=nova-opening-hours-field