Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev][hotfix/1.62.3] - Bug AB#97711 - [Connection Forms][Safari] - Public form not rendering phone number country flag icon #455

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[dev][hotfix/1.62.3] - Bug AB#97711 - [Connection Forms][Safari] - Public form not rendering phone number country flag icon #455

merged 1 commit into from
Jul 25, 2023

Conversation

ardneved
Copy link
Contributor

@ardneved ardneved commented Jul 25, 2023 •
edited by JLeeC
Loading

[dev][hotfix/1.62.3] - Bug AB#97711 - [Connection Forms][Safari] - Public form not rendering phone number country flag icon

Description

  • height and width added to svg icon used inside input flag as on safari it is required for svg's to show

cm-ui doc screenshot on safari
Screenshot 2023-07-25 at 10 37 12

local changes screenshot on safari
Screenshot 2023-07-25 at 10 36 41

@ardneved ardneved added bug priority: high Highest Priority for code review labels Jul 25, 2023
@ardneved ardneved self-assigned this Jul 25, 2023
@groberts314
Copy link
Contributor

This is gonna have to go into some hotfix branch probably.
Currently HC Admin hotfix/1.62.3 is at React CM UI 10.6.8. Latest is 10.6.11, and lots of things have changed: 10.6.8...10.6.11

@groberts314 groberts314 added risk: low Low Risk/Criticality and removed do not merge labels Jul 25, 2023
@groberts314 groberts314 added this to the vNextPatch (10.6.12) milestone Jul 25, 2023
@groberts314
Copy link
Contributor

Gonna go ahead and merge this to dev, release 10.6.12 with with change and with #454, and then will also release a hotfix version (like 10.6.8-hotfix-1) that can get integrated into HC Admin hotfix/1.62.3.

@groberts314 groberts314 merged commit 86b8303 into dev Jul 25, 2023
12 of 13 checks passed
@groberts314 groberts314 deleted the features/phone-input-flag-not-showing-on-safari branch July 25, 2023 16:21
@groberts314 groberts314 mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groberts314 groberts314 groberts314 approved these changes

@Benjamin-Gnewuch Benjamin-Gnewuch Awaiting requested review from Benjamin-Gnewuch

@KacosPro KacosPro Awaiting requested review from KacosPro

Assignees

@ardneved ardneved

Labels
bug priority: high Highest Priority for code review risk: low Low Risk/Criticality
Projects
None yet
Milestone
10.6.12
Development

Successfully merging this pull request may close these issues.
2 participants
@ardneved @groberts314