Update functions.mdx #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made the partial execution/currying easy
sadanandpai
reviewed
Jun 21, 2024
| if(ip.length < func.length) { | ||
| return curry.bind(this, ...ip); | ||
| } | ||
| return func(...ip); |
There was a problem hiding this comment.
should this not be func.apply(this, ip);
There was a problem hiding this comment.
As this function isn't called over any object and thus there is no requirement of holding the context (of this ref).
There was a problem hiding this comment.
let sum = curryFunc(function () {
console.log(this)
});
sum.call(1);I can see this fails without the proper implementation of this
sadanandpai
reviewed
Jun 21, 2024
| }; | ||
| function curryFunc(func) { | ||
| return function curry(...ip) { | ||
| if(ip.length < func.length) { |
There was a problem hiding this comment.
can we keep the func as fn and ip as args for consistency
sadanandpai
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made the partial execution/currying easy