Fixing function output and also fn argument typo #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found the following two issues in Q13 of functions-concepts. - argument name was num but sum used num1 + num2. In `strict mode` num1 will not be found ( leading to reference error ) and in non strict mode it will be undefined - The string argument which is being passed to console.log is being ignored erroneously. Hence moved the string param to end with its default value and modified the output as well.
sadanandpai
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the following two issues in Q13 of functions-concepts.
strict modenum1 will not be found ( leading to reference error ) and in non strict mode it will be undefinedFound an issue in the
proxy.callexample of Q20 of functions-concepts. as well, where it is typed undefined for the output which ideally should have been an object.