Skip to content

Conversation

@kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Oct 8, 2021

Description

  • migrate from travis to gh-actions

Motivation

Related

@phil-davis
Copy link
Contributor

@DeepDiver1975 I thought that I had access to repo settings, but it seems not. Maybe you can remove Travis as an expected CI result, and enable GitHub Actions etc?

@staabm
Copy link
Member

staabm commented Oct 8, 2021

I just removed prettyCI and travisCI from the whole sabre-io.org

@staabm
Copy link
Member

staabm commented Oct 8, 2021

after we merged the PR and the first github action was run, we can declare it as a required check

@phil-davis
Copy link
Contributor

@staabm is there a way to get the GitHub actions to run on this PR? Or do we review and "just merge it" and then see if it works?

@staabm
Copy link
Member

staabm commented Oct 8, 2021

GitHub actions to run on this PR? Or do we review and "just merge it" and then see if it works?

AFAIK the github actions would run within the PR immediately when the PR is created by a person with write-access to the repo.

for other people it runs only after merge

@phil-davis
Copy link
Contributor

for other people it runs only after merge

Yesterday I saw a button to click on PR sabre-io/xml#204 to give it permission to run the GitHub Actions CI. (That PR was from a fork) I clicked it, CI ran, passed, then we merged,

But I don't see that option here. But maybe that is because this is the very first PR that is actually implementing the GitHub actions.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we can see what happens when this is merged - I will make a PR and test and we can easily do any minor changes that are needed.

run: composer phpstan

- name: Test with PHPUnit
run: composer phpunit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO composer phpunit does not run with coverage, so we might not get any coverage data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants