-
Couldn't load subscription status.
- Fork 132
tests: migrate from Travis to GitHub-Actions #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@DeepDiver1975 I thought that I had access to repo settings, but it seems not. Maybe you can remove Travis as an expected CI result, and enable GitHub Actions etc? |
|
I just removed prettyCI and travisCI from the whole sabre-io.org |
|
after we merged the PR and the first github action was run, we can declare it as a required check |
|
@staabm is there a way to get the GitHub actions to run on this PR? Or do we review and "just merge it" and then see if it works? |
AFAIK the github actions would run within the PR immediately when the PR is created by a person with write-access to the repo. for other people it runs only after merge |
Yesterday I saw a button to click on PR sabre-io/xml#204 to give it permission to run the GitHub Actions CI. (That PR was from a fork) I clicked it, CI ran, passed, then we merged, But I don't see that option here. But maybe that is because this is the very first PR that is actually implementing the GitHub actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - we can see what happens when this is merged - I will make a PR and test and we can easily do any minor changes that are needed.
| run: composer phpstan | ||
|
|
||
| - name: Test with PHPUnit | ||
| run: composer phpunit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO composer phpunit does not run with coverage, so we might not get any coverage data.
Description
travistogh-actionsMotivation
Related