RFC 4918 compliance: Remove unexpected propstat #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC 4918, there is two types of response elements: Type 1 contains one or more href and one status child elements. Type 2 contains one href and one or more propstat child elements. Both types may contain further optional elements. For Type 1, sabre/dav inserts a spurious propstat element, which violated the element definition by RFC 4918.
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
============================================
- Coverage 97.12% 97.10% -0.02%
- Complexity 2774 2788 +14
============================================
Files 174 174
Lines 8028 8045 +17
============================================
+ Hits 7797 7812 +15
- Misses 231 233 +2
Continue to review full report at Codecov.
|
|
No one interested in fixing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 4918, there is two types of response elements:
See section 14.24, response XML Element:
Type 1 contains one or more href and one status child elements.
Type 2 contains one href and one or more propstat child elements.
Both types may contain further optional elements.
For Type 1, sabre/dav inserts a spurious propstat element, which violated the element definition by RFC 4918.
You can also see examples for such type 1 response elements in RFC 4918, for example 9.6.2 example:
This issue may cause failure with clients that validate the received XML against the RFC specification.
The attached change still allows responses to be created that contain both status and propstat child elements. I don't know your error handling concept, therefore I did not address that issue.