Skip to content

Add missing linux/module.h #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Add missing linux/module.h #14

merged 2 commits into from
Jul 18, 2018

Conversation

bachp
Copy link
Contributor

@bachp bachp commented Jul 17, 2018

The file should be included in the installed headers, but for some reason it is missing in the 3.x kernel branch.
Kernel 4.x do install it.

It defines some constants that are required to load and unload kernel modules using the corresponding syscalls.

bachp added 2 commits July 17, 2018 22:06
The header defines constants needed for module loading and unloading
It is installed in 4.x kernel but seems to be missing in 3.x
@rofl0r rofl0r merged commit 9b7ef77 into sabotage-linux:master Jul 18, 2018
@rofl0r
Copy link
Member

rofl0r commented Jul 18, 2018

thanks. where did you get the header from ? my linux 4.14 sources define the include guard as _LINUX_MODULE_H. not that it matters, just curious.

@bachp
Copy link
Contributor Author

bachp commented Jul 18, 2018

The header is from 3.12.6. It is included in the kernel uapi folder but for some reason doesn't get installed when calling make headers_install_all.

Is it possible to do a release with this change?

@rofl0r
Copy link
Member

rofl0r commented Jul 18, 2018

would that be sufficient for rust's use ? i see you also mentioned sparc64 issues, but we don't support that (yet).

@bachp
Copy link
Contributor Author

bachp commented Jul 18, 2018

@rofl0r Yes a release would be sufficient.

This is only required for the musl based builds to work and these are now all passing with my fork. But I would like to be based on an official tag if possible.

The sparc64 issues are related to the gnu (glibc) version. But I think the issue might be similar that Debian is using an old kernel as the base for their libc headers. In other worths the sparc64 issue is not related to this repo.

@rofl0r
Copy link
Member

rofl0r commented Jul 18, 2018

@bachp
Copy link
Contributor Author

bachp commented Jul 18, 2018

@rofl0r thank you

@bachp bachp deleted the module.h branch July 18, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants