Add decompose instructions, when qiskit circuit is build.#308
Merged
David-Kreplin merged 13 commits intosQUlearn:developfrom Dec 19, 2024
Merged
Add decompose instructions, when qiskit circuit is build.#308David-Kreplin merged 13 commits intosQUlearn:developfrom
David-Kreplin merged 13 commits intosQUlearn:developfrom
Conversation
MoritzWillmann
requested changes
Dec 17, 2024
Collaborator
MoritzWillmann
left a comment
There was a problem hiding this comment.
Thank you @MHagelueken for the quick fix. I have a couple of comments before we can merge this PR. Also can you please make sure the code formatting (black) checks go through 😄
Cheers Moritz
src/squlearn/encoding_circuit/circuit_library/qcnn_encoding_circuit.py
Outdated
Show resolved
Hide resolved
MoritzWillmann
requested changes
Dec 17, 2024
David-Kreplin
requested changes
Dec 18, 2024
Collaborator
David-Kreplin
left a comment
There was a problem hiding this comment.
Do we need a decomposition in encoding_circuit.transpiled_encodig_circuit.py:
if "optimization_level" not in kwargs:
kwargs["optimization_level"] = 3
if "seed_transpiler" not in kwargs:
kwargs["seed_transpiler"] = 0
self._transpiled_circuit = transpile(self._circuit, self._backend, **kwargs)
src/squlearn/encoding_circuit/circuit_library/qcnn_encoding_circuit.py
Outdated
Show resolved
Hide resolved
MoritzWillmann
approved these changes
Dec 19, 2024
David-Kreplin
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transpile() with keyword optimization_level >1 can delete gates with parameters that are redundant which leads to the code not being able to map parameters of original circuit onto transpiled circuit.
closes #306