Tutorial for the ODE QNN Regressor #307
Merged
David-Kreplin merged 20 commits intosQUlearn:developfrom Dec 20, 2024
Merged
Conversation
…coding, created nblink and modified pyproject
Collaborator
|
After our conversiation, here the are todos summerized:
|
…DE_QNN_regressor_tutorial_develop
Contributor
Author
|
Hi! I implemented all the suggested changes:
Thus, I believe is ready to be checked again @David-Kreplin. Thank you very much ! Any other feedback, I am happy to help :) |
Collaborator
David-Kreplin
left a comment
There was a problem hiding this comment.
There are a few rendering errors left:
- For the logistic differential equation, we take $ Q(x) = P(x) = -6 $ and $ n = 2$ in the Eq.
- This is, $:nbsphinx-math:mathcal{L}{:nbsphinx-math:
theta} = :nbsphinx-math:mathcal{L}{\theta}(dy/dx, y, x) + \eta:nbsphinx-math:left(y(x_0) - u_0 \right)^2 $, where
The problem is that you probably have no possibility to look at the final rendered HTML file; the notebook looks fine, on the other hand.
David-Kreplin
approved these changes
Dec 20, 2024
Collaborator
David-Kreplin
left a comment
There was a problem hiding this comment.
Loos great now, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
In this PR, I made a tutorial for the QNN ODE solver.
The logistic differential equation, a special case of the Bernoulli Differential Equation, is solved and compared to its analytical solution.
If this example is too trivial, I can search for another one.
To include the tutorial, I also:
- Created
docs/examples/example_quantum_bayesian_optimization.nblink(which I think it was necessary but I am not sure)- Included
--ignore=examples/tutorials/qnn_ode_solver.ipynb, inpyproject.tomlso that it is not checked by pychecks (as the solution takes a long time)Furthermore:
- I fixed one small typo in
examples/tutorials/quantum_bayesian_optimization.ipynb, "structre->structure"- I fixed a small bug in the
KyriienkoEncodingCircuitfor thechebyshev_productFeel free to let me know what should I improve or change. Thankss!
Roberto