Adaption of kernel optimizer#279
Merged
David-Kreplin merged 21 commits intosQUlearn:developfrom Sep 6, 2024
Merged
Conversation
David-Kreplin
requested changes
Jul 11, 2024
Collaborator
David-Kreplin
left a comment
David-Kreplin
left a comment
There was a problem hiding this comment.
Great work so far! I've added only minor remarks.
Could you also please add a small testjob for the kernel optimizer
- Implement parameterized tests for regression and classification high-level classes. - Note: Classification tests are not fully complete due to "LinAlgError: 17-th leading minor of the array is not positive definite" during Cholesky decomposition. - Further investigation and fixes needed to ensure the matrix is always positive definite.
Collaborator
|
I did some adjustments, maybe you can check them @MoritzWillmann |
David-Kreplin
approved these changes
Aug 15, 2024
Collaborator
|
I’ll take it from here. Most of the work looks great, but there are a few specifics that are a bit tedious to explain and fix, such as regularization. |
…nisKleinhans/squlearn into adaption-of-kernel-optimizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #274