Merged
Conversation
Collaborator
Author
UpdateI figured out that if if |
Collaborator
Author
|
Not sure, why this was closed |
Collaborator
|
@MoritzWillmann in my tests it works now (at least for binary) |
Collaborator
Author
|
I finally was able to fix it. LGTM 🎉 |
David-Kreplin
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current State
This PR adds a new loss class
CrossEntropyLossimplementing the multi-class log loss (aka. cross entropy loss)The value is calculated as
If the task at hand is binary, a "class" is added with prediction$1-f(x)$ and label $1-y$ .
The gradient is thus calculated as
If the task at hand is binary, a "class" is added with prediction$f(x)-1$ and label $1-y$ .
I test this functionality in
tests/qnn/test_loss.py.This PR solves #112