fixes ntrimmer bug basepair output growing in size #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rue return max size_t
|
This still doesn't address the issue of how the empty reads are getting output. |
joe-angell
commented
Aug 7, 2020
common/src/read.h
Outdated
| // number of bp that are trimmed off left side | ||
| size_t getLTrim() const { return cut_L; } | ||
| // number of bp that are trimmed off right side | ||
| size_t getRTrim() const { return (length - cut_R); } | ||
| size_t getRTrim() const { return cut_R <= cut_L ? (length - cut_L)+1 : length - cut_R; } |
There was a problem hiding this comment.
if getRTrim is the number of bp trimmed off the right side, I don't think this should be altered.
…ength() -1 in another change
|
@msettles I recommend we merge this before making the change preventing trimming of all bases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was empty reads were causing ntrimmer to set rcut 1 on empty sequence making Read::getLengthTrue return 0-1 or max size_t.