Improves gpg-encrypted get requests streamed to stdout #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trivial change improves the behaviour of gpg-encrypted get requests streamed to stdout. Previous (broken) behaviour: - Streams encrypted file contents to stdout - Streams incorrect error message to stderr - Creates empty file with pseudo-random name Current (less broken) behaviour: - Streams encrypted file contents to stdout Correct behaviour: - Streams decrypted file contents to stdout Implementing the correct behaviour would require significant architectural changes to how s3cmd decrypts gpg-encrypted contents. Current workaround to stream a gpg-encrypted get request to stdout: s3cmd --no-progress get s3://<bucket>/<file> - | gpg -d --quiet --no-use-agent --passphrase <passphrase>
|
This seems important to resolve and this PR seems trivial but has conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trivial change improves the behaviour of
gpg-encrypted get requests streamed to stdout.
Previous (broken) behaviour:
Current (less broken) behaviour:
Correct behaviour:
Implementing the correct behaviour would require
significant architectural changes to how s3cmd
decrypts gpg-encrypted contents.
Current workaround to stream a gpg-encrypted
get request to stdout:
s3cmd --no-progress get s3:/// - | gpg -d --quiet --no-use-agent --passphrase