Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore etag in the case of a KMS server side encryption #498

Closed
wants to merge 1 commit into from
Closed

Ignore etag in the case of a KMS server side encryption #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion S3/S3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,7 +1378,7 @@ def recv_file(self, request, stream, labels, start_position = 0, retries = _max_
response["md5"] = response["headers"]["etag"]

md5_hash = response["headers"]["etag"]
if not 'x-amz-meta-s3tools-gpgenc' in response["headers"]:
if (not 'x-amz-meta-s3tools-gpgenc' in response["headers"]) and (not 'x-amz-server-side-encryption-aws-kms-key-id' in response["headers"]):
# we can't trust our stored md5 because we
# encrypted the file after calculating it but before
# uploading it.
Expand Down