If response['headers'] is empty, then don't update dict. #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ceph sometime returns
{'status': 200, 'headers': {}, 'reason': '', 'data': ''}
which chokes s3cmd because headers is an empty dictionary.
|
See also deis/deis#3002 |
mdomsch
added a commit
that referenced
this pull request
Mar 5, 2015
If response['headers'] is empty, then don't update dict.
|
We're adding more and more workarounds for faulty 3rd party product implementations of the S3 API. I merged this patch, but would also prefer to see Ceph store and return headers correctly. They gave us a 200 (which to be fair, we ignored), and expected to see headers returned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ceph sometime returns
{'status': 200, 'headers': {}, 'reason': '', 'data': ''}
which chokes s3cmd because headers is an empty dictionary.