Always attempt to set the content-type #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 this is critical |
|
+1 |
6 similar comments
|
👍 |
|
+1 |
|
👍 |
|
+1 |
|
+1 |
|
+1 |
|
pls |
|
+1 |
|
Actually I change my mind. -9. BACK TO SQUARE ONE. |
mdomsch
added a commit
to mdomsch/s3cmd
that referenced
this pull request
Dec 1, 2014
Addresses issues s3tools#214, s3tools#409, and incorporates pull request s3tools#406. content_type() was trying to do too many things in line, making it hard to read. Split the part that gets the mime-type via reading a file into a helper function. This lets the command-line-provided --mime-type override file-detected methods. Raise ParameterError if file is stdin and no --mime-type or --default-mime-type has been provided. Split object_replace() out from object_copy(). Yes, they are similar. No, they're not identical. This lets us change the MIME type of a file via 's3cmd modify'. Add test cases to change the MIME type via 's3cmd modify'.
|
Please try with mdomsch tree, branch bug/content-type. Remember to use --acl-public (if that's what you want), otherwise on modify, the ACLs get reset back to default. |
|
Subsumed into Pull Request #428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401