Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Do not close datatable column menu on inside clicks #215

Merged

Conversation

votdev
Copy link
Contributor

@votdev votdev commented Jun 27, 2023

Before:
Peek 2023-06-27 12-12_before

After:
Peek 2023-06-27 12-13_after

Fixes: https://github.com/aquarist-labs/s3gw/issues/599

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR

@votdev votdev added kind/bug Something isn't working area/ui User Interface labels Jun 27, 2023
@votdev votdev added this to the v0.18.0 milestone Jun 27, 2023
@votdev votdev requested a review from jhmarina June 27, 2023 10:11
@votdev votdev self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (31cda32) 87.12% compared to head (0900ee1) 87.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files          10       10           
  Lines         396      396           
=======================================
  Hits          345      345           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@votdev votdev merged commit 7dada94 into s3gw-tech:main Jul 3, 2023
@votdev votdev deleted the issue_599_datatable_column_menu_close_outside branch July 3, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui User Interface kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Do not close datatable column menu on inside clicks
1 participant