charts/configmap: add S3GW_SERVICE_URL #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ildefons
previously approved these changes
Jul 31, 2023
sure, could be
because this is |
giubacc
suggested changes
Sep 13, 2023
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
jecluis
force-pushed
the
wip-backend-rgw-addr
branch
from
abbc12e
to
dd40840
Compare
|
@m-ildefons @giubacc updated the PR to 1) make the variable |
jecluis
changed the title
giubacc
approved these changes
Sep 13, 2023
|
to be merged after s3gw-tech/s3gw-ui#242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new configmap entry, pointing to the address of the s3gw service.
This will be consumed by the
s3gw-uibackend.We are leaving the original entry in there nonetheless so we don't break the UI if/when this gets merged, depending on whether changed to the UI get merged before or after. It should be removed in a coming release.
Signed-off-by: Joao Eduardo Luis <joao@suse.com>