IP filtering

[lekhan05]

Minimal changes required for some ip filtering, for further review and inputs only

[s-gv]

write to response like this: http.Error(w, http.StatusText(404), 404) I dunno what the appropriate http code is, so find that out! Bad request (400) is generic, so maybe we can use that unless you find a better one!

[lekhan05]

sure, ive added the appropriate ones

[s-gv]

Can you create a table for banned IPs (like in the wiki) and read banned IPs from that? This will also get you to setup postgres.

[lekhan05]

Can you create a table for banned IPs (like in the wiki) and read banned IPs from that? This will also get you to setup postgres.

sure , on to it.

[lekhan05]

Is this how we want to do this? I'll read up on what the gist index is. I think we might want to build some data structure (like Trie) by reading the entire table on application start instead of querying the banned_ips table on every query. We can refresh the data structure if the banned_ips table is modified (which I expect will be pretty rare).

yeah that was the intention , sure if we choose to go with the trie approach lets do it.

[lekhan05]

I think we'll want to keep the SQL queries in the "model" package and expose some API to the rest of the codebase. That way, if we make changes to the DB, we only have to re-write SQL in one package instead of all over the application!

sure was thinking to create some sort of data access module , will move it