Introducing a new package?

[suntong]

I want to add a new method to replace the following series of fmt.Scanf with reading from .env instead:

orangeforum/management.go

Lines 208 to 226 in 5cf2e18

	var smtpHost string
	fmt.Printf("SMTP Host: ")
	fmt.Scanf("%s\n", &smtpHost)
	var smtpPort int
	fmt.Printf("SMTP Port: ")
	fmt.Scanf("%d\n", &smtpPort)
	var smtpUser string
	fmt.Printf("SMTP User: ")
	fmt.Scanf("%s\n", &smtpUser)
	var smtpPass string
	fmt.Printf("SMTP Password: ")
	fmt.Scanf("%s\n", &smtpPass)
	var defaultFromEmail string
	fmt.Printf("Default from email: ")
	fmt.Scanf("%s\n", &defaultFromEmail)

OK?

The auto-reading from .env would be provided by github.com/joho/godotenv/autoload, to load .env file automatically.

[s-gv]

That’s for the command line setup of the admin user. So, it reading from environment variables isn’t a great fit? There are of course other ways like the admin config page to set the SMTP etc.

…

On Fri, 10 Nov 2023 at 3:33 AM, suntong ***@***.***> wrote: I want to add a new method to replace the following series of fmt.Scanf with reading from .env instead: https://github.com/s-gv/orangeforum/blob/5cf2e188f22b44db64f0f4d2722ea5c43e65151b/management.go#L208-L226 OK? The auto-reading from .env would be provided by github.com/joho/godotenv/autoload, to load .env file automatically. — Reply to this email directly, view it on GitHub <#159>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKFV5JXV63SI2SGHY23PKTYDVHJ3AVCNFSM6AAAAAA7FIE3AWVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DMNBXGIYDONA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[suntong]

That’s for the command line setup of the admin user. So, it reading from environment variables isn’t a great fit?

Hmm... I'm not replacing the current approach, but to add an option so that people can choose.

I've pushed my change so that you can take a peek --

https://github.com/suntong/orangeforum/compare/dev/newfeatures...suntong:orangeforum:dev/email?expand=1#diff-088d9f35d23a4347d221d71dd49b02b95001dff4abe637a40fe0bc04d502049c

It's fine we don't introduce a new package, I'll just define everything as environment variables for myself. Just we'll loose self-documented one-stop location for my next PR:

And the .env file will be convenient for configuring & launching the server too, as shown in the top # Runtime settings: section. Anyway, you decide.