Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address #122 #124

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Address #122 #124

merged 5 commits into from
Oct 6, 2023

Conversation

deemp
Copy link
Contributor

@deemp deemp commented Oct 1, 2023 •
edited
Loading

  • Added snippet_url parameter
  • Migrated from NextJS to Vite
  • Used setText on params attribute

@deemp deemp changed the title Migrate to vite Migrate from next to vite Oct 1, 2023
@fizruk fizruk requested a review from aabounegm October 2, 2023 08:21
@deemp deemp changed the title Migrate from next to vite Address #122 Oct 2, 2023
@deemp deemp marked this pull request as draft October 3, 2023 20:11
@deemp deemp marked this pull request as ready for review October 3, 2023 21:31
fizruk
fizruk approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@fizruk fizruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fizruk fizruk merged commit 5fd1a66 into rzk-lang:develop Oct 6, 2023
6 checks passed
@fizruk fizruk mentioned this pull request Oct 7, 2023
Merged
@aabounegm aabounegm mentioned this pull request Nov 13, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fizruk fizruk fizruk approved these changes

@aabounegm aabounegm Awaiting requested review from aabounegm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deemp @fizruk