add ignorePromise to safely ignore promise #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ignore will be more strict than the standard ignore function because it will only match Promise.t<'a>
This helps to find potential bugs:
Especially the second case has caused bugs for us so we eliminated the general
ignore
from our codebase.I called the function
ignorePromise
so it doesn't shadow when opened. It might be ok to shadow, and then we have the slightly nicerPromise.ignore
.