Fix python 3.11 support, bump async_upnp_client dependency #121
+339
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
added a commit
that referenced
this pull request
Mar 17, 2023
This maintenance release adds support to python 3.11 and bumps the required async_upnp_client version. [Full Changelog](release/0.15.1...0.15.2) **Fixed bugs:** - Songpal discover giving errors [#122](#122) - Python 3.11 not supported (asyncio.coroutine has been removed) [#120](#120) - Fix python 3.11 support, bump async_upnp_client dependency [#121](#121) (@rytilahti) **Closed issues:** - SRS-ZR7 integration connection issues [#119](#119)
Merged
rytilahti
added a commit
that referenced
this pull request
Mar 17, 2023
This maintenance release adds support to python 3.11 and bumps the required async_upnp_client version. [Full Changelog](release/0.15.1...0.15.2) **Fixed bugs:** - Songpal discover giving errors [#122](#122) - Python 3.11 not supported (asyncio.coroutine has been removed) [#120](#120) - Fix python 3.11 support, bump async_upnp_client dependency [#121](#121) (@rytilahti) **Closed issues:** - SRS-ZR7 integration connection issues [#119](#119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix python 3.11 support. This is untested and pends someone testing it on the real device, also using earlier python versions even when removal of
asyncio.coroutine()wrapping should not break anything in this case to my understanding.Also, bump
async_upnp_clientdependency as it will be required by homeassistant somepoint anyway and it includes a breaking change that affects at least the discovery (StevenLooman/async_upnp_client#144).Fixes #120
Fixes #122