Fix the default value for the notification fallback callback #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
reviewed
Sep 11, 2022
rytilahti
changed the title
Flameeyes
force-pushed
the
fix-homeassistant
branch
from
e50ad14 to
365eb8e
Compare
rytilahti
reviewed
Sep 11, 2022
Flameeyes
force-pushed
the
fix-homeassistant
branch
from
365eb8e to
9e22fe2
Compare
After rytilahti#112 the `None` value is no longer handled as a valid `fallback_callback`. This change reintroduce support for it, by considering it the same as no callback given for the notification. This was surfacing as home-assistant/core#77730.
Flameeyes
force-pushed
the
fix-homeassistant
branch
from
9e22fe2 to
92029d0
Compare
rytilahti
approved these changes
Sep 12, 2022
rytilahti
added a commit
that referenced
this pull request
Sep 12, 2022
[Full Changelog](0.15...0.15.1) **Fixed bugs:** - Fix the default value for the notification fallback callback [\#117](#117) (@Flameeyes)
Merged
|
Released 0.15.1: https://pypi.org/project/python-songpal/0.15.1/ - feel free to create a bump PR to homeassistant! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #112 the
Nonevalue is no longer a valid fallback_callbackvalue. Instead of allowing it, provide a default no-op callback that
does nothing and use that as default.
This was surfacing as home-assistant/core#77730.