Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dreame.vacuum.p2029 #1522

Merged
merged 2 commits into from
Sep 11, 2022
Merged

Conversation

escoand
Copy link
Contributor

@escoand escoand commented Sep 10, 2022

Fixes #1052

By the way:

The only difference between _DREAME_F9_MAPPING and _DREAME_TROUVER_FINDER_MAPPING is the ordering and this:

_DREAME_F9_MAPPING: MiotMapping = {
    # https://home.miot-spec.com/spec/dreame.vacuum.p2008
    # https://home.miot-spec.com/spec/dreame.vacuum.p2009
    # https://home.miot-spec.com/spec/dreame.vacuum.p2028
    # https://home.miot-spec.com/spec/dreame.vacuum.p2041o
    # https://home.miot-spec.com/spec/dreame.vacuum.p2150a
    # https://home.miot-spec.com/spec/dreame.vacuum.p2150o
    ...
    "delete_timer": {"siid": 18, "piid": 8},
    ...
}

_DREAME_TROUVER_FINDER_MAPPING: MiotMapping = {
    # https://home.miot-spec.com/spec/dreame.vacuum.p2029
    # https://home.miot-spec.com/spec/dreame.vacuum.p2036
    ...
    "delete_timer": {"siid": 8, "aiid": 1},
    ...
}

But to be honest, not even one of the specs list siid 18 but all the ssid 8 with aiid 1 as delete_timer.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #1522 (b616420) into master (d544083) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1522   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files         145      145           
  Lines       14161    14162    +1     
  Branches     3416     3416           
=======================================
+ Hits        11634    11635    +1     
  Misses       2302     2302           
  Partials      225      225           
Impacted Files Coverage Δ
...io/integrations/vacuum/dreame/dreamevacuum_miot.py 74.61% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@rytilahti rytilahti merged commit 9a0ff1f into rytilahti:master Sep 11, 2022
@escoand escoand deleted the patch-1 branch September 11, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dreame L10 Bot Pro (dreame.vacuum.p2029) support
3 participants