Make unit optional for @setting, fix type hint for choices #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix choices type
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
=======================================
Coverage 82.15% 82.15%
=======================================
Files 145 145
Lines 14161 14161
Branches 3416 3416
=======================================
Hits 11634 11634
Misses 2302 2302
Partials 225 225
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rytilahti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit is optional string
fix choices type