-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add soundpack install support for vacuum/dreame #1457
Conversation
Thanks for the PR, @GH0st3rs! Please run |
Have no idea about it
|
Feel free to ignore the doc8 tests outputs, they shouldn't break the build either. edit: #1458 fixes those doc8 errors. |
Codecov Report
@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
- Coverage 83.35% 83.24% -0.12%
==========================================
Files 139 139
Lines 13670 13693 +23
Branches 3248 3252 +4
==========================================
+ Hits 11395 11399 +4
- Misses 2057 2076 +19
Partials 218 218
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again! 👍
Fixes #1181