vacuum/roborock: Allow custom timer ids #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
force-pushed
the
fix/roborock/arbitrary_timer_ids
branch
from
1244243
to
ba63bbb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1423 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 135 135
Lines 13389 13389
Branches 1493 1493
=======================================
Hits 11289 11289
Misses 1883 1883
Partials 217 217 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valetudo apparently allow timer ids that are not based on the unix timestamp.
This PR makes it possible to use any string as an id for timers.
Related to #1416