Use result_callback (click8+) in roborock integration #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1390 +/- ##
=======================================
Coverage 84.18% 84.18%
=======================================
Files 133 133
Lines 13325 13325
Branches 1484 1484
=======================================
Hits 11217 11217
Misses 1897 1897
Partials 211 211
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Owner
|
Thanks for the PR! A related issue was fixed in #1378 but this specific case wasn't included in the fix. The workaround, which only works on released versions that do not include that PR, until next release is shipped is to downgrade manually to click7. |
rytilahti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error mentioned in #1389
The error is linux-wide, not only docker specific like mentioned in issue.
Fixes #1389