Retry on error code -9999 #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error code -9999 is a common occurence when sending invalid command to a device, but which also seems to be recoverable error on others. This PR changes the protocol behavior by retrying when -9999 response is received.
Codecov Report
@@ Coverage Diff @@
## master #1363 +/- ##
=======================================
Coverage 82.20% 82.20%
=======================================
Files 109 109
Lines 11800 11801 +1
Branches 1386 1386
=======================================
+ Hits 9700 9701 +1
Misses 1893 1893
Partials 207 207
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error code -9999 is a common occurence when sending invalid command to a device,
but which also seems to be recoverable error on others.
This PR changes the protocol behavior by retrying when -9999 response is received.
Fixes #757