Skip to content

philips_bulb: add philips.light.candle to supported devices #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

impankratov
Copy link
Contributor

Add support for philips.light.candle aka "Xiaomi Philips Rui Chi Candle Light Bulb".

Device stopped working after 2021.12 Home Assistant update, causing this warning message:

Found an unsupported model 'philips.light.candle' for class 'Device'. If this is working for you, please open an issue at ...

It was working without any problems previously (brightness and cct control at least), not sure about snm (scenes) support (never used them), although this device plugin in Mihome app shows that scenes are supported.

@impankratov impankratov force-pushed the feature/support-philips-light-candle branch 2 times, most recently from 69cc7ce to 3334c45 Compare December 12, 2021 15:26
@impankratov impankratov marked this pull request as draft December 12, 2021 15:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2021

Codecov Report

Merging #1232 (942727a) into master (4342e3d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 942727a differs from pull request most recent head 918ce2c. Consider uploading reports for the commit 918ce2c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1232   +/-   ##
=======================================
  Coverage   79.26%   79.27%           
=======================================
  Files          90       90           
  Lines        9729     9730    +1     
  Branches     1130     1130           
=======================================
+ Hits         7712     7713    +1     
  Misses       1825     1825           
  Partials      192      192           
Impacted Files Coverage Δ
miio/philips_bulb.py 96.59% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4342e3d...918ce2c. Read the comment docs.

@impankratov impankratov force-pushed the feature/support-philips-light-candle branch from 3334c45 to 942727a Compare December 12, 2021 15:32
Aka "Xiaomi Philips Rui Chi Candle Light Bulb"
@impankratov impankratov force-pushed the feature/support-philips-light-candle branch from 942727a to 918ce2c Compare December 12, 2021 15:33
@impankratov impankratov marked this pull request as ready for review December 12, 2021 15:33
@rytilahti
Copy link
Owner

The warning itself should not be an issue, but I'm wondering why your log entry is marking Device as the implementation class that is missing the model, any ideas on that?

@impankratov
Copy link
Contributor Author

impankratov commented Dec 12, 2021

@rytilahti nice catch!

You're right, I've posted wrong log message in PR description, it should say "PhilipsBulb".

@rytilahti
Copy link
Owner

I noticed that there are also other missing philips devices (among many other things) and created #1237. Would it be fine for you to close this PR in favor of that?

@impankratov
Copy link
Contributor Author

@rytilahti sure, no problem!
Closing in favor of #1237

@impankratov impankratov deleted the feature/support-philips-light-candle branch December 13, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants