mirobo: make sure config always exists

miio/integrations/vacuum/roborock/tests/test_mirobo.py

@@ -0,0 +1,14 @@
+from click.testing import CliRunner
+
+from ..vacuum_cli import cli
+
+
+def test_config_read(mocker):
+    """Make sure config file is being read."""
+    x = mocker.patch("miio.integrations.vacuum.roborock.vacuum_cli._read_config")
+    runner = CliRunner()
+    runner.invoke(
+        cli, ["--ip", "127.0.0.1", "--token", "ffffffffffffffffffffffffffffffff"]
+    )
+
+    x.assert_called()

miio/integrations/vacuum/roborock/vacuum_cli.py

@@ -33,6 +33,17 @@
 pass_dev = click.make_pass_decorator(Device, ensure=True)
 
 
+def _read_config(file):
+    """Return sequence id information."""
+    config = {"seq": 0, "manual_seq": 0}
+    with contextlib.suppress(FileNotFoundError, TypeError, ValueError), open(
+        file, "r"
+    ) as f:
+        config = json.load(f)
+
+    return config
+
+
 @click.group(invoke_without_command=True, cls=ExceptionHandlerGroup)
 @click.option("--ip", envvar="MIROBO_IP", callback=validate_ip)
 @click.option("--token", envvar="MIROBO_TOKEN", callback=validate_token)
@@ -61,13 +72,11 @@ def cli(ctx, ip: str, token: str, debug: int, id_file: str):
         click.echo("You have to give ip and token!")
         sys.exit(-1)
 
-    with contextlib.suppress(FileNotFoundError, TypeError, ValueError), open(
-        id_file, "r"
-    ) as f:
-        x = json.load(f)
-        start_id = x.get("seq", 0)
-        manual_seq = x.get("manual_seq", 0)
-        _LOGGER.debug("Read stored sequence ids: %s", x)
+    config = _read_config(id_file)
+
+    start_id = config["seq"]
+    manual_seq = config["manual_seq"]
+    _LOGGER.debug("Using config: %s", config)
 
     vac = RoborockVacuum(ip, token, start_id, debug)