Skip to content

Conversation

@martin-kokos
Copy link
Contributor

@martin-kokos martin-kokos commented Oct 8, 2021

Closes #1154

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @martin-kokos 👍 I reworded the text a bit, what do you think?

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #1155 (3ee0fc0) into master (b633844) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1155   +/-   ##
=======================================
  Coverage   76.10%   76.10%           
=======================================
  Files          76       76           
  Lines        8926     8927    +1     
  Branches      750      750           
=======================================
+ Hits         6793     6794    +1     
  Misses       1950     1950           
  Partials      183      183           
Impacted Files Coverage Δ
miio/vacuum.py 60.53% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b633844...3ee0fc0. Read the comment docs.

@martin-kokos
Copy link
Contributor Author

Yes, sure.

@rytilahti rytilahti merged commit c53595f into rytilahti:master Oct 13, 2021
@rytilahti rytilahti mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mirobo update-firmware to Roborock is unsuccessful due to Broken pipe, Got a request, should be downloading now.

3 participants