Skip to content

Add Dracula theme#11

Merged
ryo-ma merged 1 commit intoryo-ma:masterfrom
spenserblack:theme/dracula
Sep 8, 2020
Merged

Add Dracula theme#11
ryo-ma merged 1 commit intoryo-ma:masterfrom
spenserblack:theme/dracula

Conversation

@spenserblack
Copy link
Copy Markdown
Contributor

This PR adds the Dracula theme.

Trophies C and B are flat, but trophies A and S get shadows because they are more exciting 😄

What do you think?

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ryo-ma/github-profile-trophy/r51rbxihn
✅ Preview: https://github-profile-trophy-git-fork-spenserblack-theme-dracula.ryo-ma.vercel.app

@ryo-ma
Copy link
Copy Markdown
Owner

ryo-ma commented Sep 7, 2020

I think a good idea. But flat and shadow are different themes, It may damage the sense of unity. I thought that should use optional parameters for applying shadow If supporting shadow.

ex: &shadow=true

@spenserblack
Copy link
Copy Markdown
Contributor Author

spenserblack commented Sep 7, 2020

Understood. For now, it might be best if I make this theme all flat. Then &shadow=true can be implemented separately for this theme and others. What do you think?

@ryo-ma
Copy link
Copy Markdown
Owner

ryo-ma commented Sep 7, 2020

Yes. I'm glad you work. if you finished making this theme all flat, let me see.

@spenserblack
Copy link
Copy Markdown
Contributor Author

spenserblack commented Sep 8, 2020

OK, Dracula is all flat, except for the "secret" trophy. It looks like the secret trophy is never flat in any of the themes.
Dracula Trophy Theme

@ryo-ma
Copy link
Copy Markdown
Owner

ryo-ma commented Sep 8, 2020

Thanks! Good contribution! I will merge.
But I want to change the secret trophy color, text color, and rank bar color. I want to emphasize red a little more and try not to overlap with other themes.

@ryo-ma ryo-ma merged commit 4bd383f into ryo-ma:master Sep 8, 2020
@spenserblack spenserblack deleted the theme/dracula branch September 8, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants