Add key learnings to summary details #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #124 +/- ##
==========================================
+ Coverage 31.92% 33.74% +1.82%
==========================================
Files 141 139 -2
Lines 3778 3577 -201
Branches 731 707 -24
==========================================
+ Hits 1206 1207 +1
+ Misses 2307 2106 -201
+ Partials 265 264 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Update `codecov.yml` to exclude `*View.kt` and `*PreviewData.kt` files - Update `PreviewData` with key learning data
- Removed `hasVideo` and `hasGraphic` properties from `SummaryUi`. - Removed `hasVideo` and `hasGraphic` parameters from `SummaryItem` and `SummaryIndicators` composables. - Removed unused indicators from library screen. - Removed unused indicators from preview data. - Updated UI to no longer display video and graphic indicators.
…uppress the "DuplicatedCode" warning.
- Replaced the manual creation of lists with helper functions. - Created helper functions `createCategory` and `createSummary`. - Simplified the creation of `allCategories` and `allSummaries`.
- Replaced the background image on the landing screen with a new one, `landing_image`. - Changed the status bar color on the landing screen to `LandingStatusBar`. - Changed the moto text on the landing screen to "The simplest, most focused way to experience life-changing book summaries".
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
SummaryLearningsViewcomposable for displaying key learnings.Summaryentity to includekeyLearnings.SummaryUito include a list of key learnings.Issue (if applicable):
🖼 Screenshots/Videos (if applicable)
📦 Dependencies
🧪 Testing
Describe the steps to reproduce:
📱 Checklist