bump version #557
bump version #557
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughVersion numbers were bumped from 1.5.1 to 1.6.0 in Changes
Sequence Diagram(s)sequenceDiagram
participant UI as AppSidebar / SettingsSidebar
participant Auth as UserState
participant Env as Config (IS_CLOUD)
note over UI: Sidebar rendering flow
UI->>Auth: query isAdmin (for Admin link)
UI->>Env: query IS_CLOUD
alt isAdmin && IS_CLOUD
UI-->>UI: render Admin link
else otherwise
UI-->>UI: do not render Admin link
end
UI->>Env: query IS_CLOUD (for Subscription)
alt IS_CLOUD
UI-->>UI: render Subscription item
else
UI-->>UI: hide Subscription item
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
client/package.json(1 hunks)server/package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
client/**/*
📄 CodeRabbit Inference Engine (CLAUDE.md)
Frontend: Use Next.js, Tailwind CSS, Shadcn UI, Tanstack Query, Zustand, Luxon, Nivo, and react-hook-form
Files:
client/package.json
server/**/*
📄 CodeRabbit Inference Engine (CLAUDE.md)
Backend: Use Fastify, Drizzle ORM (Postgres), ClickHouse, and Zod
Files:
server/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build Client Images (ubuntu-latest, linux/amd64)
- GitHub Check: Build Client Images (ubuntu-24.04-arm, linux/arm64)
🔇 Additional comments (1)
client/package.json (1)
3-3: Version bump to 1.6.0 is appropriate and consistent.Minor version bump looks good; no changes to deps/scripts. Matches the coordinated update in server/package.json.
If the UI surfaces the app version (e.g., About modal, footer), please confirm it reads from package.json or env and that no "1.5.1" strings are hardcoded.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "rybbit-backend", | |||
| "version": "1.5.1", | |||
| "version": "1.6.0", | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Server package version updated to 1.6.0 — LGTM.
Aligned with client; metadata-only change is safe.
Run this script to ensure there are no lingering references to 1.5.1 and that release metadata is in sync (workspace roots, changelogs, docs):
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Searching for remaining 1.5.1 occurrences..."
rg -nP -g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**' '\b1\.5\.1\b' || true
echo
echo "Checking package.json version fields still at 1.5.1 (should be none)..."
rg -nP -g '!**/node_modules/**' '"version"\s*:\s*"1\.5\.1"' || true
echo
echo "Detecting workspace root package.json (if present) and its version..."
fd -H '^package\.json$' -td -E node_modules -E dist -E build \
--exec bash -lc 'for f; do if jq -e ".workspaces" "$f" >/dev/null 2>&1; then echo "Workspace root: $f"; jq -r ".name, .version // \"(no version field)\"" "$f"; fi; done' || true
echo
echo "Checking for changelog files mentioning 1.6.0..."
fd -a -H 'CHANGELOG*.md' -E node_modules -E dist -E build \
| xargs -I{} sh -c 'echo "--- {} ---"; rg -n "1\\.6\\.0" "{}" || true'
echo
echo "Listing tags matching v1.6.x (may be empty in PR context)..."
git tag -l 'v1.6.*' || trueLength of output: 2093
Lockfiles need version sync
The bump of server/package.json to 1.6.0 is correct, but the corresponding lockfiles still list the old 1.5.1 version at their top‐level version field. Please regenerate the lockfiles so they match the new package version and eliminate project‐level 1.5.1 entries.
• server/package-lock.json – top‐level "version": "1.5.1" → should be "1.6.0"
• client/package-lock.json – top‐level "version": "1.5.1" → should be updated if the client was bumped to 1.6.0
After running npm install (or the appropriate install command) in each workspace, confirm there are no remaining non‐dependency references to 1.5.1.
🤖 Prompt for AI Agents
In server/package.json around line 3 the package version was bumped to 1.6.0 but
the workspace lockfiles still contain a top-level "version": "1.5.1"; regenerate
lockfiles by running npm install (or npm ci) in each workspace (server and
client as applicable) so server/package-lock.json and client/package-lock.json
update their top-level "version" to 1.6.0, then verify there are no remaining
non-dependency references to 1.5.1 (search project files) before committing the
updated lockfiles.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
client/src/components/AppSidebar.tsx (3)
8-11: Sort internal imports alphabetically within the group (per guidelines).Alphabetize the internal imports to match the repo’s import ordering rules.
Apply:
-import { useAdminPermission } from "../app/admin/hooks/useAdminPermission"; -import { cn } from "../lib/utils"; -import { useEmbedablePage } from "../app/[site]/utils"; -import { IS_CLOUD } from "../lib/const"; +import { useEmbedablePage } from "../app/[site]/utils"; +import { useAdminPermission } from "../app/admin/hooks/useAdminPermission"; +import { IS_CLOUD } from "../lib/const"; +import { cn } from "../lib/utils";
48-56: Behavior change: Admin link now shows only in cloud. Confirm product intent and coerce to boolean.
- Product check: This hides Admin for self-hosted even if the user is admin. Confirm this is intended.
- Minor safety: If
IS_CLOUDisn’t strictly boolean, coerce it to avoid truthy "false".- Note: Hiding the link is not an access control; ensure server-side/route guards still enforce admin-only access.
Apply:
-{isAdmin && IS_CLOUD && ( +{isAdmin && !!IS_CLOUD && (
24-26: Tailwind class looks invalid: "duration-1s00".Likely a typo; Tailwind uses values like duration-100, duration-300, duration-700, duration-1000. Consider correcting to the intended value (e.g., duration-1000 for 1s).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
client/src/components/AppSidebar.tsx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
{client,server}/**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (CLAUDE.md)
{client,server}/**/*.{ts,tsx}: Use TypeScript with strict typing throughout both client and server
Use try/catch blocks with specific error types for error handling
Use camelCase for variables and functions, PascalCase for components and types
Group imports by external, then internal, and sort alphabetically within groups
Files:
client/src/components/AppSidebar.tsx
client/**/*
📄 CodeRabbit Inference Engine (CLAUDE.md)
Frontend: Use Next.js, Tailwind CSS, Shadcn UI, Tanstack Query, Zustand, Luxon, Nivo, and react-hook-form
Files:
client/src/components/AppSidebar.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build Client Images (ubuntu-24.04-arm, linux/arm64)
- GitHub Check: Build Client Images (ubuntu-latest, linux/amd64)
🔇 Additional comments (1)
client/src/components/AppSidebar.tsx (1)
11-11: IS_CLOUD is client-safe and strictly boolean
In client/src/lib/const.ts,IS_CLOUDis sourced fromprocess.env.NEXT_PUBLIC_CLOUDand compared with=== "true", yielding a true boolean value. No further changes are needed.
Summary by CodeRabbit
Chores
Changes