Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#358) fix agile glitches rounding and blink #360

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

ryanw-mobile
Copy link
Owner

Agile screen UI minor fixes:

  • Unified current rate tile and rate cells to use the same correct rounding function - provided by KoalaPlot. Our own rounding function is not delivering the expected results and we intended to ditch KoalaPlot, so eventually, we have to fix ours.
  • Hoist the blinking text alpha animations at the parent Agile screen level, so all rate cells, when blink, will have the same effects in-sync,

@ryanw-mobile ryanw-mobile added the fix A bug fix for the user, not a fix to a build script. label Nov 12, 2024
@ryanw-mobile ryanw-mobile requested a review from rwmobi November 12, 2024 00:44
@ryanw-mobile ryanw-mobile self-assigned this Nov 12, 2024
@ryanw-mobile ryanw-mobile linked an issue Nov 12, 2024 that may be closed by this pull request
Copy link
Contributor

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-1.96% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (66a5ab9) 2652 2253 84.95%
Head commit (5eecb95) 2899 (+247) 2406 (+153) 82.99% (-1.96%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#360) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@ryanw-mobile ryanw-mobile merged commit 9ca6fe4 into main Nov 12, 2024
4 of 5 checks passed
@ryanw-mobile ryanw-mobile deleted the fix/358-agile-glitches-rounding-and-blink branch November 12, 2024 01:06
@ryanw-mobile ryanw-mobile restored the fix/358-agile-glitches-rounding-and-blink branch November 12, 2024 03:05
@ryanw-mobile ryanw-mobile deleted the fix/358-agile-glitches-rounding-and-blink branch November 12, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix for the user, not a fix to a build script.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agile screen UI glitches - rounding and blink effect
2 participants