App: fix Gradle to work with AGP 9.0

[ryanw-mobile]

Overview

This PR updates the project's build infrastructure to use Android Gradle Plugin (AGP) 9.0.0 and JDK 21. It also streamlines the Gradle build logic and updates the development environment requirements.
​

Changes

​

🛠 Build & Dependencies

• AGP Upgrade: Bumped agp version from 8.13.2 to 9.0.0.
• JDK 21 Migration:
  • Updated sourceCompatibility and targetCompatibility to JavaVersion.VERSION_21.
  • Updated Kotlin jvmToolchain to 21.
  • Updated GitHub Actions workflows (renovate_check.yml, tag_create_release.yml) to use JDK 21.
• Dependency Updates:
  • Updated Dagger Hilt to 2.59.
  • Updated KSP to 2.3.4 (aligned with Kotlin 2.3.0).
• Plugin Cleanup: Removed the redundant jetbrainsKotlinAndroid plugin as it's now handled by the Android Application and Compose Compiler plugins.
  ​

⚙️ Gradle Logic Improvements

• Modernized DSL: Replaced internal BaseAppModuleExtension with the public ApplicationExtension in build utility functions.
• Signing Configuration:
  • Introduced a releaseSigning property to conditionally enable release signing.
  • Added better logging during the keystore search process.
• Cleanup: Removed legacy APK renaming logic (setOutputFileName) that relied on internal AGP APIs.
• Project Properties: Set android.nonFinalResIds=true in gradle.properties for better build performance and compatibility with modern AGP.
  ​

📝 Documentation

• README Update: Updated the "Let's download and run it!" section to reflect the requirement for Android Studio Otter and JDK 21.

[amazon-q-developer]

Review Summary

This PR successfully upgrades the project to Android Gradle Plugin (AGP) 9.0.0 and JDK 21. The changes are well-structured and align with modern Android development practices.

✅ Positive Changes

• AGP 9.0 Migration: Proper upgrade from AGP 8.13.2 to 9.0.0
• JDK 21 Adoption: Updated Java compatibility and Kotlin JVM toolchain to version 21
• API Modernization: Replaced internal BaseAppModuleExtension with public ApplicationExtension API
• Plugin Cleanup: Removed redundant jetbrainsKotlinAndroid plugin (now handled by Android Application plugin)
• Build Configuration: Added conditional release signing with releaseSigning property
• Legacy Code Removal: Cleaned up deprecated APK renaming logic that used internal AGP APIs

🔧 Critical Issue Found

There is 1 critical compilation error that needs to be addressed:

• Missing import for BasePluginExtension which will cause build failures

📋 Dependencies Updated

• Dagger Hilt: 2.58 → 2.59
• KSP: Updated to 2.3.4 (aligned with Kotlin 2.3.0)
• Gradle Properties: Set android.nonFinalResIds=true for AGP 9.0 compatibility

The upgrade approach is sound, but the missing import must be fixed before merge.

---

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51d1257a77

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".